Narcissus/nwipe
2
0
Fork 0
mirror of https://github.com/martijnvanbrummelen/nwipe.git synced 2026-02-20 13:42:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix overflow warning message.

Browse Source 
Use sizeof to determine suitable string size for the dmidecode cmd buffer
This commit is contained in:
PartialVolume
2020-03-10 15:18:25 +00:00
parent 69e27abf2b
commit 88cae05301
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/logging.c
View File

@@ -395,7 +395,6 @@ int nwipe_log_sysinfo()
{
FILE* fp;
char path[256];
char cmd[50];
int len;
int r; // A result buffer.
@@ -428,6 +427,11 @@ int nwipe_log_sysinfo()
"processor-frequency",
"" // terminates the keyword array. DO NOT REMOVE
};
char dmidecode_command[] = "dmidecode -s %s";
char cmd[sizeof(dmidecode_keywords)+sizeof(dmidecode_command)];
unsigned int keywords_idx;
keywords_idx = 0;
@@ -435,7 +439,7 @@ int nwipe_log_sysinfo()
/* Run the dmidecode command to retrieve each dmidecode keyword, one at a time */
while( dmidecode_keywords[keywords_idx][0] != 0 )
{
sprintf( cmd, "dmidecode -s %s", &dmidecode_keywords[keywords_idx][0] );
sprintf( cmd, dmidecode_command, &dmidecode_keywords[keywords_idx][0] );
fp = popen( cmd, "r" );
if( fp == NULL )
{