The test doesn't make sense. It just exits without any error if the
binary doesn't exist, which is silly.
Replace the NETWORKMANAGER_BIN variable, which was used only once, by
the full path of the binary file.
Drop the now useless variables prefix, exec_prefix and sbindir.
Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Sometimes it is useful to pass some parameters to NetworkManager when it
starts (e.g. --log-level) instead of editting NetworkManager.conf. Allow
the user add a file with a NETWORKMANAGER_ARGS variable containing such
flags. This is simpler than overriding the whole startup script (e.g. by
means of a rootfs overlay).
Signed-off-by: Carlos Santos <casantos@datacom.ind.br>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
'echo -n' is not a POSIX construct (no flag support), we shoud use
'printf', especially in init script.
This patch was generated by the following command line:
git grep -l 'echo -n' -- `git ls-files | grep -v 'patch'` | xargs sed -i 's/echo -n/printf/'
Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
The pidof -o option is only available in the Busybox applet if
CONFIG_FEATURE_PIDOF_OMIT is enabled, and it isn't really needed here as the
init script isn't called 'NetworkManager', so get rid of it.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
"<command> &>/dev/null" is supposed to redirect all output to /dev/null.
However, in shells that don't support it (dash, ash without bash extensions),
a command like "echo a &>/dev/null" is interpreted as
(a) "echo a" in background
(b) write nothing to /dev/null (redirect <empty command> to /dev/null)
This commit replaces "&>..." with ">/dev/null 2>&1".
Signed-off-by: André Erdmann <dywi@mailerd.de>
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Even though it's most commonly used on desktops, this piece of software
also works well on embedded devices.
The package file only resolved mandatory dependencies. Things like
iptables and dnsmasq are only required if 'shared' connections are used,
and have hence not been made hard prerequisites.
There are probably too many i18n related files installed to the target.
That might need some more tweaking.
[Peter: fix Kconfig dependencies, add execinfo patch, fix libgcrypt-config
path, uClibc build fix]
Signed-off-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>