From 69d6d9708cd1cbb1bdece151967652cee3b9a2bd Mon Sep 17 00:00:00 2001 From: louib Date: Sun, 14 Jun 2020 14:03:57 -0400 Subject: [PATCH 1/4] Moving formatting to a new GH action. --- .github/workflows/ci_formatting.yml | 22 ++++++++++++++++++++++ .github/workflows/ci_ubuntu_16.04.yml | 5 +---- .github/workflows/ci_ubuntu_latest.yml | 5 +---- 3 files changed, 24 insertions(+), 8 deletions(-) create mode 100644 .github/workflows/ci_formatting.yml diff --git a/.github/workflows/ci_formatting.yml b/.github/workflows/ci_formatting.yml new file mode 100644 index 0000000..3c5a120 --- /dev/null +++ b/.github/workflows/ci_formatting.yml @@ -0,0 +1,22 @@ +name: ci_formatting + +on: [push, pull_request] + +jobs: + build: + + runs-on: ubuntu-latest + + steps: + - uses: actions/checkout@v1 + - name: updating available system dependencies + run: sudo apt-get update + - name: installing system dependencies + run: sudo apt-get install -y build-essential pkg-config automake clang-format-5.0 + - name: creating autoconf files + run: ./init.sh + - name: configuring + run: ./configure CFLAGS='-O0 -g -Wall -Wextra' + # Changing the path should no longer be necessary when clang-format6 is installed. + - name: verifying code style + run: export PATH=$PATH:/usr/lib/llvm-5.0/bin && make check-format diff --git a/.github/workflows/ci_ubuntu_16.04.yml b/.github/workflows/ci_ubuntu_16.04.yml index 22ddf0a..41b2ce1 100644 --- a/.github/workflows/ci_ubuntu_16.04.yml +++ b/.github/workflows/ci_ubuntu_16.04.yml @@ -12,13 +12,10 @@ jobs: - name: updating available system dependencies run: sudo apt-get update - name: installing system dependencies - run: sudo apt-get install -y build-essential pkg-config automake libncurses5-dev autotools-dev libparted-dev dmidecode clang-format-5.0 + run: sudo apt-get install -y build-essential pkg-config automake libncurses5-dev autotools-dev libparted-dev dmidecode - name: creating autoconf files run: ./init.sh - name: configuring run: ./configure CFLAGS='-O0 -g -Wall -Wextra' - name: compiling run: make - # Changing the path should no longer be necessary when clang-format6 is installed. - - name: verifying code style - run: export PATH=$PATH:/usr/lib/llvm-5.0/bin && make check-format diff --git a/.github/workflows/ci_ubuntu_latest.yml b/.github/workflows/ci_ubuntu_latest.yml index 740219a..73c2819 100644 --- a/.github/workflows/ci_ubuntu_latest.yml +++ b/.github/workflows/ci_ubuntu_latest.yml @@ -12,13 +12,10 @@ jobs: - name: updating available system dependencies run: sudo apt-get update - name: installing system dependencies - run: sudo apt-get install -y build-essential pkg-config automake libncurses5-dev autotools-dev libparted-dev dmidecode clang-format-5.0 + run: sudo apt-get install -y build-essential pkg-config automake libncurses5-dev autotools-dev libparted-dev dmidecode - name: creating autoconf files run: ./init.sh - name: configuring run: ./configure CFLAGS='-O0 -g -Wall -Wextra' - name: compiling run: make - # Changing the path should no longer be necessary when clang-format6 is installed. - - name: verifying code style - run: export PATH=$PATH:/usr/lib/llvm-5.0/bin && make check-format From 4075b4b50e895ec385ff86cb24527db5af7b0bf4 Mon Sep 17 00:00:00 2001 From: louib Date: Sun, 14 Jun 2020 14:07:35 -0400 Subject: [PATCH 2/4] missing deps. --- .github/workflows/ci_formatting.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci_formatting.yml b/.github/workflows/ci_formatting.yml index 3c5a120..61e21b6 100644 --- a/.github/workflows/ci_formatting.yml +++ b/.github/workflows/ci_formatting.yml @@ -11,8 +11,10 @@ jobs: - uses: actions/checkout@v1 - name: updating available system dependencies run: sudo apt-get update + - name: TODO remove + run: apt-cache search clang-format - name: installing system dependencies - run: sudo apt-get install -y build-essential pkg-config automake clang-format-5.0 + run: sudo apt-get install -y build-essential pkg-config automake libncurses5-dev autotools-dev libparted-dev dmidecode clang-format-5.0 - name: creating autoconf files run: ./init.sh - name: configuring From d830db3c1c87a0f6175f3a955a9124490c57af0c Mon Sep 17 00:00:00 2001 From: louib Date: Sun, 14 Jun 2020 14:10:22 -0400 Subject: [PATCH 3/4] Bumping to clang-format-7 --- .github/workflows/ci_formatting.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci_formatting.yml b/.github/workflows/ci_formatting.yml index 61e21b6..cdad050 100644 --- a/.github/workflows/ci_formatting.yml +++ b/.github/workflows/ci_formatting.yml @@ -14,11 +14,10 @@ jobs: - name: TODO remove run: apt-cache search clang-format - name: installing system dependencies - run: sudo apt-get install -y build-essential pkg-config automake libncurses5-dev autotools-dev libparted-dev dmidecode clang-format-5.0 + run: sudo apt-get install -y build-essential pkg-config automake libncurses5-dev autotools-dev libparted-dev dmidecode clang-format-7 - name: creating autoconf files run: ./init.sh - name: configuring run: ./configure CFLAGS='-O0 -g -Wall -Wextra' - # Changing the path should no longer be necessary when clang-format6 is installed. - name: verifying code style - run: export PATH=$PATH:/usr/lib/llvm-5.0/bin && make check-format + run: make check-format From 7c10bc85a3b76963be10222bbe8837e0fb46a5dd Mon Sep 17 00:00:00 2001 From: louib Date: Sun, 14 Jun 2020 14:13:07 -0400 Subject: [PATCH 4/4] Remove apt-cache search from formatting job. --- .github/workflows/ci_formatting.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/ci_formatting.yml b/.github/workflows/ci_formatting.yml index cdad050..6ed4b7c 100644 --- a/.github/workflows/ci_formatting.yml +++ b/.github/workflows/ci_formatting.yml @@ -11,8 +11,6 @@ jobs: - uses: actions/checkout@v1 - name: updating available system dependencies run: sudo apt-get update - - name: TODO remove - run: apt-cache search clang-format - name: installing system dependencies run: sudo apt-get install -y build-essential pkg-config automake libncurses5-dev autotools-dev libparted-dev dmidecode clang-format-7 - name: creating autoconf files